Store last loaded playlist #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/queue/Playlist.hxx
Outdated
| @@ -102,6 +102,9 @@ struct playlist { | |||
| [[gnu::pure]] | |||
| int GetNextPosition() const noexcept; | |||
|
|
|||
| const std::string getLastLoadedPlaylist() const noexcept; | |||
There was a problem hiding this comment.
Bad method name, but the worst thing is that this allocates a copy of the string on the heap.
There was a problem hiding this comment.
Renamed to starting uppercase and converted to std::string_view. I hope this is correct!
src/queue/Queue.cxx
Outdated
| @@ -270,6 +270,7 @@ Queue::Clear() noexcept | |||
| } | |||
|
|
|||
| length = 0; | |||
| last_loaded_playlist = ""; | |||
There was a problem hiding this comment.
This has a smell - last_loaded_playlist.clear(); is better and faster
src/queue/Queue.hxx
Outdated
| @@ -85,6 +85,9 @@ struct Queue { | |||
| /** play back songs in random order? */ | |||
| bool random = false; | |||
|
|
|||
| /** Last loaded playlist */ | |||
| std::string last_loaded_playlist = ""; | |||
There was a problem hiding this comment.
This initializer has no effect (except for adding runtime overhead)
jcorporation
force-pushed
the
queue_loaded_playlist
branch
from
f7c08dc
to
bb36989
Compare
|
There's no protocol documentation; and the |
Stores the last loaded playlist uri in the queue struct. Last loaded playlist is set on load command and cleared with the clear command. The last loaded playlist is printed in the status command and saved / restored from the partition state file. Resolves issue MusicPlayerDaemon#938
jcorporation
force-pushed
the
queue_loaded_playlist
branch
from
bb36989
to
bfbff31
Compare
|
Added documentation and inlined the functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores the last loaded playlist uri in the queue struct. Last loaded playlist is set on load command and cleared with the clear command. The last loaded playlist is printed in the status command and saved / restored from the partition state file.
Resolves issue #938