Skip to content

Conversation

@madrisan
Copy link

No description provided.

Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
madrisan added 2 commits July 15, 2024 09:07
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
@madrisan madrisan force-pushed the ci branch 2 times, most recently from 0f80422 to 40b65b3 Compare July 15, 2024 07:23
madrisan added 2 commits July 15, 2024 09:43
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
madrisan added 2 commits July 15, 2024 09:46
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
@madrisan madrisan changed the title ci: run the black linter ci: add a basic CI running linter and tests Jul 15, 2024
@madrisan madrisan marked this pull request as draft July 15, 2024 08:11
@madrisan
Copy link
Author

sqlite3.OperationalError: no such table: licenses

How can I create the SQLite DB?

madrisan added 2 commits July 15, 2024 10:19
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
Signed-off-by: Davide Madrisan <d.madrisan@proton.me>
@glenl
Copy link
Contributor

glenl commented Jul 15, 2024

python3 mupub init

This will create the ~/.mupub folder containing an intialized database, configuration files, and lycache. (Apparently the lycache isn't getting created on init and I will fix that soon.)

@madrisan
Copy link
Author

Thanks!
I switched to a copy of this repository for testing a possible CI:
https://github.com/madrisan/mupub/tree/ci

By the way @glenl , why mupub checks for lilypondVersion instead of lookinh at \version?
A grep in MutopiaProject/MutopiaProject gives me no occurrences.

@glenl
Copy link
Contributor

glenl commented Jul 16, 2024

See header.py - The tag in mupub's Loader table is named lilypondVersion but it resolves that from a match for \version.

_VERSION_PAT = re.compile(r'\s*\\version\s+\"([^\"]+)\"')

... and in the VersionLoader method,

                vmatch = _VERSION_PAT.search(line)
                if vmatch is not None:
                    table['lilypondVersion'] = vmatch.group(1)

BTW, other than being the author and (reasonably) happy with the work, I have no other personal stake. If you want to continue support, feel free to rewrite and modify as you see fit. It is no longer "mine". For example, he SQLite DB part was an implementation decision I made and you might feel it is better served with YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants