Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass custom loads and dumps to JsonFormatter #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow to pass custom loads and dumps to JsonFormatter #13

wants to merge 1 commit into from

Conversation

mahenzon
Copy link

@mahenzon mahenzon commented Aug 5, 2021

Closes #12

@mahenzon mahenzon force-pushed the feature/custom-json-lib branch from 42abb78 to a98b7bf Compare August 5, 2021 13:56
@mahenzon mahenzon changed the title Allow to pass custom loads and dumps to JSONFormatter Allow to pass custom loads and dumps to JsonFormatter Aug 5, 2021
@MyColorfulDays
Copy link
Owner

Hi, @mahenzon I'm sorry for replying so late, but very happy and thank you for the PR.
I have a question, dose the signature of other libs same as python standard dumps/loads?
If not, this will cause error.

@mahenzon
Copy link
Author

Hi! Hmm, I didn't check it. I'll do some tests and get back with an answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use custom json lib for encoding
2 participants
@mahenzon @MyColorfulDays