Skip to content

chore(form-field-text-like): Manual accessibility updates (WIP) #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

jason-evans-genesys
Copy link
Collaborator

@jason-evans-genesys jason-evans-genesys commented Jan 28, 2025

✅ Closes: COMUI-3408

*Update: spoke with @katie-bobbe-genesys and the current solution in this PR is not what we want so will brainstorm some other ideas.

@jason-evans-genesys jason-evans-genesys self-assigned this Jan 28, 2025
Copy link

@jason-evans-genesys jason-evans-genesys changed the title chore(form-field-text-like): Manual accessibility updates chore(form-field-text-like): Manual accessibility updates (WIP) Jan 30, 2025
@jason-evans-genesys
Copy link
Collaborator Author

jason-evans-genesys commented Jan 30, 2025

@katie-bobbe-genesys I set the input's aria-describedby to be the id of the loading element, however, this doesn't seem to trigger anything new from the screenreader when using voiceover on mac. Are we sure aria-describedby is needed here? I just wanted to make sure I wasn't missing something.

@jason-evans-genesys jason-evans-genesys changed the title chore(form-field-text-like): Manual accessibility updates (WIP) chore(form-field-text-like): Manual accessibility updates Feb 5, 2025
@katie-bobbe-genesys
Copy link
Collaborator

@jason-evans-genesys I took a look and aria-describedby won't work here because of how linking id's works across the shadow dom. The input component is in the light dom while the loading-indicator is in the shadow dom. So because of this the id won't link to the aria-describedby. I think we might need to do something similar to how we handled the suffix and prefix? But may need some changes to account for the fact that the loading indicator is not a slot. Let me know if you would like me to take a closer look here

@jason-evans-genesys jason-evans-genesys changed the title chore(form-field-text-like): Manual accessibility updates chore(form-field-text-like): Manual accessibility updates (WIP) Feb 10, 2025
@@ -210,6 +210,7 @@ <h2>Examples</h2>
<gux-form-field-text-like loading>
<input slot="input" type="text" name="e-1" />
<label slot="label">Default</label>
<span slot="loading">Content is loading</span>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katie-bobbe-genesys my idea was to slot in the loading text and then read it out to the screenreader.

@daragh-king-genesys daragh-king-genesys deleted the feature/COMUI-3408-v2 branch March 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants