feat(form-field-label-indicator): add none variant #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3409 |
| @@ -112,16 +112,50 @@ <h2>Examples</h2> | |||
| </fieldset> | |||
|
|
|||
| <fieldset> | |||
| <legend>Optional Indicator Mark</legend> | |||
| <legend>Indicator Mark</legend> | |||
There was a problem hiding this comment.
@katie-bobbe-genesys I don't think there was anything wrong with the component just that the documentation/example was a little confusing.
I have made a change to the text-area form field component example and if others agree it is clearer I will duplicate it in the other form field components
packages/genesys-spark-components/src/components/stable/gux-form-field/gux-form-field.types.ts
Show resolved
Hide resolved
321gillian
changed the title
321gillian
reviewed
Jan 30, 2025
...ponents/src/components/stable/gux-form-field/components/gux-form-field-textarea/example.html
Outdated
Show resolved
Hide resolved
daragh-king-genesys
force-pushed
the
feature/COMUI-3409
branch
3 times, most recently
from
71f7ed6 to
cffbf74
Compare
...components/src/components/stable/gux-form-field/components/gux-form-field-color/example.html
Outdated
Show resolved
Hide resolved
katie-bobbe-genesys
approved these changes
Jan 31, 2025
addd none variant ✅ Closes: COMUI-3409
daragh-king-genesys
force-pushed
the
feature/COMUI-3409
branch
from
cffbf74 to
0f1a95f
Compare
katie-bobbe-genesys
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addd none variant
✅ Closes: COMUI-3409