Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide dialogs for thermostat #110

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

Tony763
Copy link

@Tony763 Tony763 commented Oct 20, 2022

Description

Divided dialogs for thermostat. This should fix issue #92.

Type of PR

Either delete those that do not apply, or add an x between the square brackets like so: - [x]

  • Bugfix
  • Feature implementation
  • Refactor of code (without functional changes)
  • Documentation improvements
  • Test improvements

Testing

Added Behave tests.

Tests pass when PR #109 is applied.

@Tony763
Copy link
Author

Tony763 commented Oct 20, 2022

When #109 will be merged, I will rebase this with it.

@Tony763
Copy link
Author

Tony763 commented Dec 20, 2022

Hi @krisgesling, this one was also rebased. All tests passed in my repo.
Please add “Secure” label, too.

@krisgesling krisgesling added the secure Code has been reviewed and is safe to execute in Github Actions. label Dec 20, 2022
@github-actions github-actions bot removed the secure Code has been reviewed and is safe to execute in Github Actions. label Dec 20, 2022
@Tony763
Copy link
Author

Tony763 commented Dec 20, 2022

Allure tests Ok, skill log OK (tracker intent error only, fixed by #112), ready to go 🚀

Copy link

@krisgesling krisgesling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Tony!

@krisgesling krisgesling merged commit 6cfacf5 into MycroftAI:20.08 Dec 22, 2022
@Tony763 Tony763 deleted the feature/issue92-rebase branch December 22, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants