Use package-relative imports in buildcompiler#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
buildcompiler.pyto package-relative imports.Description
src/buildcompiler/buildcompiler.pyto usefrom .abstract_translator import translate_abstract_to_plasmids,from .sbol2build import golden_gate_assembly_plan, andfrom .robotutils import assembly_plan_RDF_to_JSON, run_opentrons_script_with_json_to_zipso internal imports are package-scoped.Testing
python -m pytest, which executed the test suite but ended with4 failed, 5 passed, 3 errorsdue to network/proxy failures contacting external SBOL services; ranruff check ., which reported many existing lint issues across notebooks and scripts (these are preexisting and not caused by this change).Codex Task