Skip to content

Transformation Workflow #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kerem-G wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Transformation Workflow #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion frontend/src/activities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export const Activities = {
objectTypesToList: [
ObjectTypes.Plasmids.id,
ObjectTypes.Strains.id,
ObjectTypes.Assembly.id,
ObjectTypes.Transformations.id,
Comment on lines 62 to 64
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve access to legacy assembly-plan files

Dropping ObjectTypes.Assembly.id from the Build activity removes the only explorer bucket that can surface existing assembly-plan assets, but the app still classifies OneDrive files under assemblyPlans/*.json as synbio.object-type.assembly-plan (mapOneDriveItemToObjectType in frontend/src/microsoft-utils/oneDrive/fetchFromOneDrive.js). After this change, users with pre-existing assembly plans can no longer find/open those files from the workflow UI, which is a regression in data accessibility unless a migration/fallback path is added.

Useful? React with 👍 / 👎.

]
Comment on lines 61 to 65
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes ObjectTypes.Assembly, but there is still code elsewhere that classifies files/folders as synbio.object-type.assembly-plan (e.g., OneDrive mapping for the assemblyPlans subdirectory). After this change, those files will become unclassified/invisible in the explorer. Consider updating the remaining classifier/mapping logic or providing a migration path so existing assemblyPlans content is handled intentionally.

Copilot uses AI. Check for mistakes.
},
Expand Down
48 changes: 0 additions & 48 deletions frontend/src/components/panels/assembly-editor/AssemblyPanel.jsx
View file
Open in desktop

This file was deleted.

Loading
Loading