Create Deployment Environments #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Term definitions have been edited to match definitions approved in the ESCO report.
Added sentence including URL for ADMG CASEI Inventory Terms Definitions
…y check that the URL is correct and don't also need to validate the content of the page.
Removed header text check on after explore page navigation.
Feature/data products view
Fix/data products
Bug fix/issue 505
* Guard against failing keyword parse * Add product table tooltip * Add link out to gcmd
* Reduce gloassary page padding * Update top margins for section headers * Add glossary data-cy prop * Add initial formats query * Add data format filter * Add data formats to instruments and platforms * Update test and snapshot * Guards against missing doi formats
* Replace collection periods * Update platform tests
* Add modal and banner to header * Update header snapshot * Make release banner pos relative * Refactor release banner to own component * Update header snapshot * Temporarily disable header text check
edkeeble
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm creating github environments for separate deployments between staging and production. This PR addresses an issue with the Coming Soon page where I had used the same API for both staging and production. We can now deploy each branch with the respective environment variable and separate APIs for our deployments.
Note: I had to fix a number of smaller issue with this deployment since we recently updates our backend infrastructure. I moved some of the data parsing logic into custom resolvers in gatsby-node.js, which I believe to be a better place for that logic.