Merge pull request #590 from NASA-IMPACT/fix/pdf-caption

Fix captions in export
NASA-IMPACT · Aug 15, 2024 · f27bf4d · f27bf4d
2 parents 418fc75 + aedb713
commit f27bf4d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/app/assets/scripts/components/documents/pdf-preview/index.js b/app/assets/scripts/components/documents/pdf-preview/index.js
@@ -243,7 +243,7 @@ function PdfPreview() {
       setDocument(applyNumberCaptionsToDocument(atbd.data.document));
       waitForImages();
     }
-  }, [atbd.status]);
+  }, [atbd.status, atbd.data]);
 
   // This useEffect is responsible for generating the ToC and numbering
   // after the document is transformed

diff --git a/app/assets/scripts/utils/apply-number-captions-to-document.js b/app/assets/scripts/utils/apply-number-captions-to-document.js
@@ -1,4 +1,3 @@
-import get from 'lodash.get';
 import {
   IMAGE_BLOCK,
   TABLE_BLOCK
@@ -80,16 +79,9 @@ export function applyNumberCaptionsToDocument(document) {
                   return c;
                 }
 
-                const currentCaption = get(c, 'children[0].text');
-
                 return {
                   ...c,
-                  children: [
-                    {
-                      ...c.children[0],
-                      text: `${captionPrefix}${currentCaption}`
-                    }
-                  ]
+                  children: [{ text: captionPrefix }, ...c.children]
                 };
               });