Merge pull request #566 from NASA-IMPACT/fix/equation-number-repetition

Fix equation number repetition
NASA-IMPACT · Oct 20, 2023 · fe57369 · fe57369
2 parents 7783e33 + 71de924
commit fe57369
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/app/assets/scripts/components/slate/plugins/equation/equation-element.js b/app/assets/scripts/components/slate/plugins/equation/equation-element.js
@@ -42,6 +42,7 @@ function EquationElement(props) {
   const isSelected = useSelected();
   const { element, attributes, children } = props;
   const latexEquation = Node.string(element);
+  const equationPath = JSON.stringify(ReactEditor.findPath(editor, element));
   const readOnly = useReadOnly();
 
   const handleClick = useCallback(() => {
@@ -60,9 +61,9 @@ function EquationElement(props) {
 
   useEffect(() => {
     if (numberingContext && !isInline) {
-      numberingContext.registerEquation(latexEquation);
+      numberingContext.registerEquation(equationPath);
     }
-  }, [numberingContext, isInline, latexEquation]);
+  }, [numberingContext, isInline, equationPath]);
 
   const returnElement = React.useMemo(() => {
     if (readOnly) {
@@ -83,7 +84,7 @@ function EquationElement(props) {
             <MathElement math={latexEquation || 'latex~empty~equation'} />
           </span>
           {!isInline && numberingContext && (
-            <span>{numberingContext.getEquationNumbering(latexEquation)}</span>
+            <span>{numberingContext.getEquationNumbering(equationPath)}</span>
           )}
           {!isInline && <span className='equation-number' />}
         </EquationReadOnly>
@@ -110,6 +111,7 @@ function EquationElement(props) {
     isInline,
     isSelected,
     latexEquation,
+    equationPath,
     numberingContext,
     readOnly
   ]);