Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/journal styling #548

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Fix/journal styling #548

merged 7 commits into from
Oct 5, 2023

Conversation

kamicut
Copy link
Collaborator

@kamicut kamicut commented Sep 28, 2023

Checklist from @bwbaker1's feedback. doc for more details and screenshots.

  • Centered title
  • Unique affiliations should be listed with superscripts
  • Duplicate affiliations should not be listed
  • Corresponding author name/email should be listed right below the affiliations and above the keypoints.
  • Key Points should be bulleted (previously, a carriage return automatically adds a bullet point)
  • Remove document information (Version, Release date, and DOI)
  • Page break after Key Points
  • Keywords have double colons (::). One of these needs to be removed.
  • Algorithm Usage Constraints should be section 4, not section 9
  • Fix remaining heading numbering (see doc, point 9)

@kamicut
Copy link
Collaborator Author

kamicut commented Sep 28, 2023

This is what the affiliations look like now in the draft PR:

Screenshot 2023-09-28 at 6 19 32 PM

@kamicut
Copy link
Collaborator Author

kamicut commented Sep 28, 2023

Bullet point styles for key points

image

@kamicut kamicut marked this pull request as ready for review October 2, 2023 12:57
Copy link
Member

@wrynearson wrynearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything you checked off looks good @kamicut!

One issue I found is with multi-level lists – they only have the content, and not the list itself. Do you have any idea why that is?

image image

@wrynearson
Copy link
Member

wrynearson commented Oct 4, 2023

☝️ somewhat works locally and on staging for document pdfs but not for journal PDFs. For document pdfs, the levels are labeled, but not correctly.

image

If these are easy fixes @kamicut, let's add them to this PR, otherwise we can merge it as is and ticket the bugs.

@kamicut
Copy link
Collaborator Author

kamicut commented Oct 4, 2023

I've pushed a fix for that issue in this PR @wrynearson

Copy link
Member

@wrynearson wrynearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kamicut! LGTM

@wrynearson wrynearson merged commit 793d4a5 into develop Oct 5, 2023
14 checks passed
@wrynearson wrynearson deleted the fix/journal-styling branch October 5, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants