Fix figure caption position #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y applyNumberCaptionsToDocument function
wrynearson
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
LGTM! I tested this on both PDF types.
FWIW, a future feature could be to add these numbers for captions (figures, but also table) into the view mode, based on this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue raised at NASA-IMPACT/nasa-apt#681 (comment).
This changes the transformer function
applyNumberCaptionsToDocumentto revert caption position only for table blocks. I've also removed code related to tables and figures from the numbering context, because it conflicts with the transformer. I've chosen to use the transformer instead of the numbering context for tables/figures captions because the later doesn't handle positioning.@frozenhelium @wrynearson this is ready for review. Please confirm if tables are position above and figures below on PDF previews.