Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document info modal citation #581

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix document info modal citation #581

merged 3 commits into from
Mar 26, 2024

Conversation

kamicut
Copy link
Collaborator

@kamicut kamicut commented Mar 20, 2024 •
edited
Loading

The document info modal uses the identifying information step and formats the author, publisher and DOI into a citation.

Upstream ticket: NASA-IMPACT/nasa-apt#825

Here's what's fixed:

  • Correctly format authors
  • Proper formatting for DOI / Website

@kamicut kamicut requested a review from wrynearson March 20, 2024 15:57
@kamicut kamicut mentioned this pull request Mar 20, 2024
Closed
@kamicut kamicut marked this pull request as ready for review March 22, 2024 14:55
wrynearson
wrynearson approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@wrynearson wrynearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test on staging (not working locally for me)

@wrynearson wrynearson merged commit a89ef35 into develop Mar 26, 2024
14 checks passed
@wrynearson wrynearson deleted the fix/825-citation-format branch March 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrynearson wrynearson wrynearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamicut @wrynearson