Skip to content

Conversation

@botanical
Copy link
Member

@botanical botanical commented Dec 11, 2025

Summary:

https://github.com/NASA-IMPACT/veda-architecture/issues/677

Changes

  • Created a DAG to tag a list of collections with a tenant property
  • Added a function to fix normalizing dates, which I noticed when I was testing updating collections with my DAG

PR Checklist

  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests
  • Infrastructure changes - test using terraform validate and terraform plan

@botanical botanical marked this pull request as ready for review December 12, 2025 22:12
@botanical
Copy link
Member Author

@sandrahoang686 Thanks for the review, I believe I addressed all your feedback.

I made one additional change to update the DAG to handle newlines for a collections list since this seems to be the convention that airflow uses for list params.
https://airflow.apache.org/docs/apache-airflow/stable/_modules/airflow/example_dags/example_params_ui_tutorial.html
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/params.html#use-params-to-provide-a-trigger-ui-form

Copy link
Contributor

@ividito ividito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but no blockers

@botanical botanical merged commit 5bd326a into dev Jan 12, 2026
4 checks passed
@botanical botanical deleted the issue-677/tenant-tagging-dag branch January 12, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants