-
Notifications
You must be signed in to change notification settings - Fork 3
fix: add redirect uris and web origins for dev and prod veda configs #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff for stage: DefaultStageWarning 1 Destructive Changes Diff for stack: veda-keycloak-dev - 0 to add, 2 to update, 0 to destroy ❌Details
Resources
[~] AWS::ECS::TaskDefinition configConfigTaskDef650ED3A2 replace
└─ [~] ContainerDefinitions (requires replacement)
└─ @@ -28,7 +28,7 @@
[ ] ],
[ ] "Essential": true,
[ ] "Image": {
[-] "Fn::Sub": "853558080719.dkr.ecr.us-west-2.${AWS::URLSuffix}/cdk-hnb659fds-container-assets-853558080719-us-west-2:520bb4e8962ce12a466680f51a1744ecd19b1a43cd22a6db0e7a04a64cfa7ee0"
[+] "Fn::Sub": "853558080719.dkr.ecr.us-west-2.${AWS::URLSuffix}/cdk-hnb659fds-container-assets-853558080719-us-west-2:fb966ebf4ef6a1ff83177a7bc6e26283830d31d9e2e58c5d1c6f014929b48458"
[ ] },
[ ] "LogConfiguration": {
[ ] "LogDriver": "awslogs",
[~] AWS::CloudFormation::Stack sesrelayNestedStacksesrelayNestedStackResource3873FD90
└─ [~] TemplateURL
└─ [~] .Fn::Join:
└─ @@ -5,6 +5,6 @@
[ ] {
[ ] "Ref": "AWS::URLSuffix"
[ ] },
[-] "/cdk-hnb659fds-assets-853558080719-us-west-2/438971a29285689505b77c1c681adaea2c3c7091c78906e9c145a245f193080f.json"
[+] "/cdk-hnb659fds-assets-853558080719-us-west-2/97ec3ae709f2ed786b6793ea2e88e26dadadb061ac967926f345c8e58cc537eb.json"
[ ] ]
[ ] ]
Generated for commit 6ec5ef5 at 2026-01-09T23:16:15.604Z |
smohiudd
reviewed
Jan 9, 2026
smohiudd
reviewed
Jan 9, 2026
smohiudd
requested changes
Jan 9, 2026
Contributor
smohiudd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redirect urls won't work with wildcard
Co-authored-by: Saadiq Mohiuddin <34844565+smohiudd@users.noreply.github.com>
smohiudd
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds redirect uris to our APIs so that it doesn't get overridden on every redeploy.