-
Notifications
You must be signed in to change notification settings - Fork 3
feat: CMS client #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: CMS client #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff for stage: DefaultStageWarning 1 Destructive Changes Diff for stack: veda-keycloak-dev - 1 to add, 3 to update, 0 to destroy ❌Details
IAM Statement Changes
┌───┬──────────────────────────────────────────┬────────┬───────────────────────────────┬─────────────────────────────────────────────────┬───────────┐
│ │ Resource │ Effect │ Action │ Principal │ Condition │
├───┼──────────────────────────────────────────┼────────┼───────────────────────────────┼─────────────────────────────────────────────────┼───────────┤
│ + │ ${configearthgovcmsclientsecret90151005} │ Allow │ secretsmanager:DescribeSecret │ AWS:${configConfigTaskDefExecutionRole55730F7C} │ │
│ │ │ │ secretsmanager:GetSecretValue │ │ │
└───┴──────────────────────────────────────────┴────────┴───────────────────────────────┴─────────────────────────────────────────────────┴───────────┘
(NOTE: There may be security-related changes not in this list. See https://github.com/aws/aws-cdk/issues/1299)
Resources
[+] AWS::SecretsManager::Secret configearthgovcmsclientsecret90151005
[~] AWS::ECS::TaskDefinition configConfigTaskDef650ED3A2 replace
└─ [~] ContainerDefinitions (requires replacement)
└─ @@ -28,7 +28,7 @@
[ ] ],
[ ] "Essential": true,
[ ] "Image": {
[-] "Fn::Sub": "853558080719.dkr.ecr.us-west-2.${AWS::URLSuffix}/cdk-hnb659fds-container-assets-853558080719-us-west-2:21855b61879599739ff8005edf119dfa23c25f0bb1a5333c14b15256d06f75ca"
[+] "Fn::Sub": "853558080719.dkr.ecr.us-west-2.${AWS::URLSuffix}/cdk-hnb659fds-container-assets-853558080719-us-west-2:49f391dfd96777b717c35a6b84d63d6e0ed777ca272a5fdb3847db2bc13f1c26"
[ ] },
[ ] "LogConfiguration": {
[ ] "LogDriver": "awslogs",
@@ -295,6 +295,34 @@
[ ] }
[ ] },
[ ] {
[+] "Name": "EARTH_GOV_CMS_CLIENT_ID",
[+] "ValueFrom": {
[+] "Fn::Join": [
[+] "",
[+] [
[+] {
[+] "Ref": "configearthgovcmsclientsecret90151005"
[+] },
[+] ":id::"
[+] ]
[+] ]
[+] }
[+] },
[+] {
[+] "Name": "EARTH_GOV_CMS_CLIENT_SECRET",
[+] "ValueFrom": {
[+] "Fn::Join": [
[+] "",
[+] [
[+] {
[+] "Ref": "configearthgovcmsclientsecret90151005"
[+] },
[+] ":secret::"
[+] ]
[+] ]
[+] }
[+] },
[+] {
[ ] "Name": "GHGC_AIRFLOW_STAC_ETL_CLIENT_ID",
[ ] "ValueFrom": {
[ ] "Fn::Join": [
[~] AWS::IAM::Policy configConfigTaskDefExecutionRoleDefaultPolicyB2F7D3D0
└─ [~] PolicyDocument
└─ [~] .Statement:
└─ @@ -134,6 +134,16 @@
[ ] ],
[ ] "Effect": "Allow",
[ ] "Resource": {
[+] "Ref": "configearthgovcmsclientsecret90151005"
[+] }
[+] },
[+] {
[+] "Action": [
[+] "secretsmanager:GetSecretValue",
[+] "secretsmanager:DescribeSecret"
[+] ],
[+] "Effect": "Allow",
[+] "Resource": {
[ ] "Ref": "configghgcairflowstacetlclientsecret51E33BCC"
[ ] }
[ ] },
[~] AWS::CloudFormation::Stack sesrelayNestedStacksesrelayNestedStackResource3873FD90
└─ [~] TemplateURL
└─ [~] .Fn::Join:
└─ @@ -5,6 +5,6 @@
[ ] {
[ ] "Ref": "AWS::URLSuffix"
[ ] },
[-] "/cdk-hnb659fds-assets-853558080719-us-west-2/d615cee391c4ead91c4e9ec15cf5927799383ce6d86835e911ec21425e50dde6.json"
[+] "/cdk-hnb659fds-assets-853558080719-us-west-2/a42ef7d79c64103083488b767412e35429389f38ee1bb609ccc2674b7f669ce0.json"
[ ] ]
[ ] ]
Generated for commit 7fa1c3f at 2026-01-30T21:22:36.490Z |
Member
|
Looks good to me |
slesaad
approved these changes
Feb 2, 2026
anayeaye
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179
Adds CMS client + group to preprod Keycloak instance. Client config was exported (and cleaned up) to maintain fidelity to console testing.