Astropy updates 2023.07 #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 76.80% 76.84% +0.03%
==========================================
Files 78 78
Lines 6984 6974 -10
==========================================
- Hits 5364 5359 -5
+ Misses 1620 1615 -5
|
|
@mkelley can you give me some context for this PR? I remember seeing a relevant message from someone astropy, but didn't keep track of it. Thanks. |
|
This address issue #372, and simplifies the Afrho/Efrho code. |
|
And removes some code from the testing setup in conftest.py Since we do not support astropy < 4.3, none of these lines are executed in our tests, which is why the coverage is increased by this PR. |
jianyangli
approved these changes
Jul 25, 2023
|
Thanks Mike. All looks good to me. I also linked this PR with issue #372 if that's OK with you. |
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supported astropy is >=4.3. Remove code branches for astropy < 4. Remove commented out reference to a deprecated astropy method.