Provide correct slope for color ratios with SpectralGradient.from_color

[mkelley]

Addresses #389

[mkelley]

To be done: rebase after #383 is merged. Update change log.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.99%. Comparing base (035041e) to head (f5b9938).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files          88       88           
  Lines        8108     8109    +1     
=======================================
+ Hits         6729     6730    +1     
  Misses       1379     1379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pep8speaks]

Hello @mkelley! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file sbpy/spectroscopy/tests/test_specgrad.py:

Line 40:10: E131 continuation line unaligned for hanging indent

Comment last updated at 2024-08-28 15:09:26 UTC

[hhsieh00]

Sorry, just getting to this now. In the code diff view, Codecov indicates that there are several new lines not covered by tests. Is this a problem (I note that the Codecov summary report on this page says that all "coverable" lines are covered)? Otherwise, the changes look good to me.

[mkelley]

Those reported lines don't make sense. They show up as covered in the codecov app: https://app.codecov.io/gh/NASA-Planetary-Science/sbpy/pull/392/blob/sbpy/spectroscopy/core.py

[mkelley]

I've rebased. Maybe that will fix them? If not, I think the coverage report should take precedence.

[hhsieh00]

Okay, that sounds fine to me. Yeah, the contradiction between the different reports is a bit strange (I still see the comments in the code diffs).

[mkelley]

I can refresh the codecov check and it'll report 100% covered as it should. But the diff report always lists those lines as uncovered. Anyway, something to keep in mind in other reviews.