Skip to content

Fix OmnidirectionalSightline feature rendering on modern devices #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix OmnidirectionalSightline feature rendering on modern devices #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions worldwind/src/main/res/raw/gov_nasa_worldwind_sightlineprogram_frag.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@

#ifdef GL_FRAGMENT_PRECISION_HIGH
precision highp float;
uniform highp sampler2D depthSampler;
#else
precision mediump float;
uniform mediump sampler2D depthSampler;
#endif

uniform float range;
uniform vec4 color[2];
uniform sampler2D depthSampler;

varying vec4 sightlinePosition;
varying float sightlineDistance;
Expand All @@ -32,7 +33,7 @@ void main() {
/* Compute a mask that's on when the object's depth is less than the sightline's depth. The depth texture contains
the scene's minimum depth at each position, from the sightline's point of view. */
vec3 sightlineCoord = clipCoord * 0.5 + 0.5;
float sightlineDepth = texture2D(depthSampler, sightlineCoord.xy).z;
float sightlineDepth = texture2D(depthSampler, sightlineCoord.xy).r;
float occludeMask = step(sightlineDepth, sightlineCoord.z);

/* Modulate the RGBA color with the computed masks to display fragments according to the sightline's configuration. */
Expand Down