-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place #653
base: main
Are you sure you want to change the base?
Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place #653
Conversation
…an modules in the correct place (NCAR#4) Update CMakeLists.txt to: - Bring in updates from NCAR ccpp-framework main as needed and update CMakeLists.txt to modern cmake version 3 - Support NEPTUNE cmake build while retaining compatibility with UFS/SCM
@climbfuji Thanks for updating and modernizing the cmake file. |
No, neither this nor the corresponding ccpp-physics PR NCAR/ccpp-physics#1119 I can do the tests this week. |
I opened a PR into the SCM with these and the physics changes for testing via CI, NCAR/ccpp-scm#568 |
Thanks very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay but I did not review super carefully (I do not use this).
Update src/CMakeLists.txt: use modern cmake features to install Fortran modules in the correct place
Update CMakeLists.txt to modern cmake version 3 and support NEPTUNE cmake build while retaining compatibility with UFS/SCM
User interface changes?: No
Fixes: [Github issue #s] n/a
Testing: all CI tests pass, ran
capgen
andprebuild
tests locally on my laptop - all passtest removed:
unit tests:
system tests:
manual testing:
Associated PRs: