Skip to content

Use array bounds for optional variable bounds checks #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gold2718
Copy link
Collaborator

In order for bounds checking of optional array variables to succeed, the check should use the array's real lower and upper bounds instead of 1 and the array's size.

User interface changes?: No

Fixes: #651

Testing:
test removed:
unit tests:
system tests: PASS
manual testing: Check for proper code generation

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test for this? This all looks good but would be nice to see it in action :-)

@dustinswales
Copy link
Member

@gold2718 I'm confused by these changes. #651 is not related to optional variables.

@gold2718
Copy link
Collaborator Author

@gold2718 I'm confused by these changes. #651 is not related to optional variables.

Also, it does not work properly.

@gold2718 gold2718 closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants