Skip to content

Add SDF and associated changes for using nTiedtke deep convective scheme #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

grantfirl
Copy link
Collaborator

  • add new SDF based on SCM_GFS_v15p2 that exercises the nTiedtke deep convection scheme, based on the FV3_GFS_2017_ntiedtke suite in the "unused" suite directory of fv3atm
  • add physics namelist consistent with new SCM_GFS_v15p2 suite
  • add default configuration for new suite in suite_info.py
  • add new suite to RT setup
  • add back suite object in run_scm.py; it was removed a while ago, but this breaks the ability to run a single, unsupported suite/case

…; add back import of suite class in run_scm.py to run single unsupported cases
@matusmartini
Copy link

@grantfirl Thank you for adding this suite. Are you waiting for this to be merged first and then proceed with NCAR/ccpp-physics#1025

@grantfirl
Copy link
Collaborator Author

@grantfirl Thank you for adding this suite. Are you waiting for this to be merged first and then proceed with NCAR/ccpp-physics#1025

@matusmartini No, I'm waiting for a review approval. @dustinswales @mkavulich @scrasmussen @hertneky

@grantfirl
Copy link
Collaborator Author

Once there is an approval, I'll merge NCAR/ccpp-physics#1025 first, then this.

@grantfirl
Copy link
Collaborator Author

@scrasmussen @mkavulich @hertneky RTs pass with the exception of missing baselines for the new test for the new suite, as expected. Once approved/merged, please update the baselines on mohawk.

Copy link
Collaborator

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@grantfirl grantfirl merged commit 8b12a30 into NCAR:main Feb 4, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants