Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color scheme, branding, and streamline custom CSS #133

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

kafitzgerald
Copy link
Collaborator

PR Summary

Updates the:

  • color scheme - updates color scheme to use NSF NCAR colors for primary (with the exception of the dark theme primary color which is a lighter version of 1A658F to help with contrast), secondary, and table hover colors
  • branding - color scheme updates and text in the footer (though this doesn't seem to be showing up any more either locally or in the deployed version Custom footer text no longer visible #132)
  • streamlines custom CSS - merged all custom css into the style.css file and removed customizations either left over from prior themes, related to color schemes, or that didn't seem to be active (this could probably use a more thorough review)

Related Tickets & Documents

Closes #53
Closes #129

Copy link

github-actions bot commented Oct 25, 2024

Meowdy! See your PR preview:
🔍 Git commit SHA: 4288334
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/133

@kafitzgerald kafitzgerald marked this pull request as ready for review October 25, 2024 15:41
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I definitely thought we needed theme_overrides.css separately, but as we're not using the same card things that necessitated its use in other repos and I bet my knowledge is outdated since the last time I played around with it, I'm good with removing it!

@kafitzgerald
Copy link
Collaborator Author

Huh, I definitely thought we needed theme_overrides.css separately, but as we're not using the same card things that necessitated its use in other repos and I bet my knowledge is outdated since the last time I played around with it, I'm good with removing it!

The docs were a little murky, but it seemed like the app mechanism that we used w/ that file mostly just provides some additional flexibility / functionality that we don't actually use so the style.css should cover it I think.

@kafitzgerald kafitzgerald merged commit be45760 into NCAR:main Oct 25, 2024
2 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional NSF NCAR branding updates [GA-1529] Update the color scheme
3 participants