Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link checker ignore mathworks sign #159

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

cyschneck
Copy link
Contributor

@cyschneck cyschneck commented Dec 11, 2024

PR Summary

The mathworks site does not seem to agree with the link checker, so while the link works as expected this is the second time it has thrown a 403 Client Error when accessing the link for the Matlab sign function

This PR adds this link to the list of links to ignore in conf.py

(ncl/ncl_entries/general_applied_math: line 770004) broken https://www.mathworks.com/help/matlab/ref/double.sign.html - 403 Client Error: Forbidden for url: https://www.mathworks.com/help/matlab/ref/double.sign.html

Related Tickets & Documents

Closes #160

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist

@cyschneck cyschneck self-assigned this Dec 11, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

github-actions bot commented Dec 11, 2024

Meowdy! See your PR preview:
🔍 Git commit SHA: e9590a4
✅ Deployment Preview URL: https://NCAR.github.io/geocat-applications/_preview/159

@cyschneck cyschneck changed the title update matlab sign link Linkchecker ignore mathworks sign Dec 11, 2024
@cyschneck cyschneck changed the title Linkchecker ignore mathworks sign Link checker ignore mathworks sign Dec 11, 2024
@cyschneck cyschneck marked this pull request as ready for review December 11, 2024 22:56
Copy link
Member

@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love adding links to ignore in case they break in the future, but I don't have a reasonable better suggestion here for now.

@cyschneck
Copy link
Contributor Author

I don't love adding links to ignore in case they break in the future, but I don't have a reasonable better suggestion here for now.

Agreed, but a similar alternative link to the sign function in matlab throws the same error. I suspect it has something to do with how mathworks set up their website

@cyschneck cyschneck merged commit 8b7fe46 into NCAR:main Dec 11, 2024
3 checks passed
@cyschneck cyschneck deleted the sign_link branch December 11, 2024 23:15
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link checker failing on mathlab sign
3 participants