Update Jetstream2 Matthew tutorial for MS-CC workshop #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in this batch: * Add information about getting ACCESS allocations. * Put SSH key info into a dropdown as it is no longer required. * Update the instance requirements section. More changes are coming.
Changes here include: * Pivoting the logging in section to using Web Desktop. * Moving the Managing an Instance section to the end. * Removing the Docker installation section. * Adding a visualization section after METplus runs. * Other odds and ends.
georgemccabe
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
These changes look good to me. I did not review the content changes, as I am not familiar with those instructions, but I did discuss these changes with @Trumbore and trust that his changes are correct and accurate.
I did confirm that the drop-down menu is rendered properly in this section: https://i-wrf--71.org.readthedocs.build/en/71/Users_Guide/matthewjetstream.html#create-a-cloud-instance-on-jetstream2
I approve.
|
Thanks, George!
Ben
From: George McCabe ***@***.***>
Sent: Monday, October 28, 2024 2:31 PM
To: NCAR/i-wrf ***@***.***>
Cc: Ben Trumbore ***@***.***>; Mention ***@***.***>
Subject: Re: [NCAR/i-wrf] Update Jetstream2 Matthew tutorial for MS-CC workshop (PR #71)
@georgemccabe approved this pull request.
These changes look good to me. I did not review the content changes, as I am not familiar with those instructions, but I did discuss these changes with @Trumbore<https://github.com/Trumbore> and trust that his changes are correct and accurate.
I did confirm that the drop-down menu is rendered properly in this section: https://i-wrf--71.org.readthedocs.build/en/71/Users_Guide/matthewjetstream.html#create-a-cloud-instance-on-jetstream2
I approve.
-
Reply to this email directly, view it on GitHub<#71 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSTCHRD6EQRQDBQF4JNWBTZ5Z7FLAVCNFSM6AAAAABQXOJPTCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJZHA4DGOBWHE>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes