Feature/40 build wrf container #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith 120 processes on a single node.
…o reduce the size of the image.
…, we copy over compiled libaries and applications, and only install the intel runtime packages so that we can redistribute the code (i.e., omits Intel compilers). Size is also down considerably from 8 GB to 3 GB.
…ith icx.
ungrib still does not compile without code modifications:
mpicc -D_UNDERSCORE -DBYTESWAP -DLINUX -DIO_NETCDF -DIO_BINARY -DIO_GRIB1 -DBIT32 -D_MPI -D_UNGRIB -w -c cio.c
cio.c:52:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
c_open(unit, nunit, name, mode, err, oflag)
^
int
cio.c:24:16: note: expanded from macro 'c_open'
#define c_open c_open_
^
cio.c:117:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
bn_seek(fd, bread, mode, iprint)
^
int
cio.c:27:17: note: expanded from macro 'bn_seek'
#define bn_seek bn_seek_
^
cio.c:155:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
bn_read(fd, buf, nbuf, bread, ios, idiag)
^
int
cio.c:26:17: note: expanded from macro 'bn_read'
#define bn_read bn_read_
^
cio.c:201:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
bnwrit_(fd, buf, nbuf, bwritten, err, idiag)
^
int
cio.c:235:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
c_close(nunit, iprint, err)
^
int
cio.c:25:17: note: expanded from macro 'c_close'
#define c_close c_close_
^
5 errors generated.
make[1]: [Makefile:96: cio.o] Error 1 (ignored)
…ow ISO C99 syntax rules to allow base compilation with icx with no flags disabling warnings/errors. Updated the build_wrf.sh script to include functions to check the build status of each component and exit if something fails.
… we created. Changing files to be owned by root for apptainer purposes. WRF needs to run the compile step twice to build everything successfully.
hahnd
added
component: Docker
47 tasks
georgemccabe
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes