-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per #73, reorganized use case documentation and added templates for future use #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one requested change: Please remove the heading/link for the Generic CONUS "interesting weather". At one point we thought we were going to pursue something like that, but then the Hurricane Matthew case wound up serving as our initial tutorial/demo entry point instead. But once you make those small changes, I approve this PR without needing a second review, and you can go ahead and merge them. Thanks for doing this.
docs/Users_Guide/usecases.rst
Outdated
@@ -2,32 +2,27 @@ | |||
Use Cases | |||
********* | |||
|
|||
Generic CONUS “interesting weather” | |||
Generic CONUS "interesting weather" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the heading/link for the Generic CONUS "interesting weather". At one point we thought we were going to pursue something like that, but then the Hurricane Matthew case wound up serving as our initial tutorial/demo entry point instead.
@jaredalee I do need another approving review in order to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @briannen. Good to go now.
Documentation only changes, see https://i-wrf--74.org.readthedocs.build/en/74/Users_Guide/usecases.html to review
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes