Remove local copy of state in solver functions (#639)

remove local copy of state in solver functions
NCAR · Aug 30, 2024 · 89d9ee5 · 89d9ee5
1 parent 5f0f7a1
commit 89d9ee5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/include/micm/solver/backward_euler.inl b/include/micm/solver/backward_euler.inl
@@ -67,7 +67,7 @@ namespace micm
     bool singular = false;
 
     auto Yn = state.variables_;
-    auto Yn1 = state.variables_;
+    auto& Yn1 = state.variables_; // Yn1 will hold the new solution at the end of the solve
     auto forcing = state.variables_;
 
     while (t < time_step)
@@ -162,7 +162,6 @@ namespace micm
       H = std::min(H, time_step - t);
     }
 
-    state.variables_ = Yn1;
     result.final_time_ = t;
     return result;
   }

diff --git a/include/micm/solver/rosenbrock.inl b/include/micm/solver/rosenbrock.inl
@@ -13,7 +13,7 @@ namespace micm
 
     SolverResult result{};
     result.state_ = SolverState::Running;
-    MatrixPolicy Y = state.variables_;
+    MatrixPolicy& Y = state.variables_; // Y will hold the new solution at the end of the solve
     std::size_t num_rows = Y.NumRows();
     std::size_t num_cols = Y.NumColumns();
     MatrixPolicy Ynew(num_rows, num_cols);
@@ -192,7 +192,6 @@ namespace micm
 
     result.final_time_ = present_time;
     result.stats_ = stats;
-    state.variables_ = Y;
 
     return result;
   }