-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
279 make solve function for ode solvers thread safe #322
Merged
mattldawson
merged 35 commits into
main
from
279-make-solve-function-for-ode-solvers-thread-safe
Oct 27, 2023
Merged
279 make solve function for ode solvers thread safe #322
mattldawson
merged 35 commits into
main
from
279-make-solve-function-for-ode-solvers-thread-safe
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 96.59% 96.39% -0.20%
==========================================
Files 34 36 +2
Lines 2728 2718 -10
==========================================
- Hits 2635 2620 -15
- Misses 93 98 +5
☔ View full report in Codecov by Sentry. |
K20shores
requested review from
boulderdaze,
mattldawson and
dwfncar
and removed request for
boulderdaze
October 26, 2023 17:39
…ttps://github.com/NCAR/micm into 279-make-solve-function-for-ode-solvers-thread-safe
mattldawson
approved these changes
Oct 27, 2023
mattldawson
deleted the
279-make-solve-function-for-ode-solvers-thread-safe
branch
October 27, 2023 21:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
Anything that needs to change throughout a solve for a thread now lives on the state. The solver is thread safe assuming each thread has its own state. The test for this is the openmp test. The only way I could verify this was by making each thread share a state. When the threads share a state, the solver never seems to finish, probably because each thread is overwriting the shared data and the error calculation never works properly and the solver keeps trying to divide the timestep.
Many things changed.