182 surface reaction example #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dwfncar could you move this to the analytical tests? That's where the other tests like this are |
Yes, hadn't ever looked at that file, so wasn't sure where this belonged. Will add the EXPECT_NEAR assertions as well. |
…o analytical_policy.hpp.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 37 37
Lines 2852 2852
=======================================
Hits 2740 2740
Misses 112 112 ☔ View full report in Codecov by Sentry. |
|
Added TEST(AnalyticalExamplesRosenbrock, SurfaceRxn) and JIT version. PR ready for review. |
K20shores
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for #326 merge, to add the new state printer header and print state methods.
Should this test be made into a full science example?
Setup was copied from https://github.com/open-atmos/camp/blob/main/test/unit_rxn_data/test_rxn_surface.F90
closes #182