Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an interface to the micm State #217

Open
K20shores opened this issue Sep 10, 2024 · 0 comments
Open

Provide an interface to the micm State #217

K20shores opened this issue Sep 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@K20shores
Copy link
Collaborator

K20shores commented Sep 10, 2024

In fortran we have to call solve with many arguments

call micm%solve(time_step, temperature, pressure, air_density, concentrations, &
user_defined_reaction_rates, solver_state, solver_stats, error)

The same is true in python

musica.micm_solve(
solver,
time_step,
temperature,
pressure,
air_density,
ordered_concentrations,
ordered_rate_constants)

Provide access to the micm state class, or at least a wrapper around the state class so that both languages can make a state and set variables on it and then call solve with state.

This will decrease the number of copies we have to do. Also, we won't create a new state each time we all solve since the state is reusable so we should be able to have a slightly faster simulation

Acceptance criteria

  • A new State class is created and accessible everywhere

Ideas

  • We need to figure out how this issue in micm gets resolved for us to really figure this out
@K20shores K20shores added the enhancement New feature or request label Sep 10, 2024
@K20shores K20shores added this to the MICM, TUV-x in CAM-SIMA milestone Sep 10, 2024
@K20shores K20shores self-assigned this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant