Store a state alongside the solver #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
boulderdaze
approved these changes
Oct 2, 2024
Comment on lines
200
to
+201
| void Solve( | ||
| auto &solver, | ||
| auto &solver_state_pair, |
There was a problem hiding this comment.
Could you update the line 192 so it can include the description for the State?
/// @param solver Pointer to solver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
Using this version of musica in music box makes the slow example Sancy pointed out extremely fast to run, though the construction still takes about 5 seoncds
This is a temporary fix. #217 will provide an interface to the state that python could hold and use directly