Skip to content

Commit

Permalink
Merge pull request #12 from bnlawrence/numpy_prod
Browse files Browse the repository at this point in the history
Use `numpy.prod` instead on `numpy.product`
  • Loading branch information
bnlawrence committed Jul 22, 2024
2 parents 67c93e0 + 8fec70b commit 1a44248
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ name: Python package

on:
push:
branches: [ master ]
branches: [ master, issue60 ]
pull_request:
branches: [ master ]

Expand All @@ -30,6 +30,7 @@ jobs:
python -m pip install flake8 pytest
python -m pip install -e .
if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
python -m pip list
- name: Lint with flake8
run: |
# stop the build if there are Python syntax errors or undefined names
Expand Down
2 changes: 1 addition & 1 deletion pyfive/dataobjects.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def unpack_attribute(self, offset):

# read in the dataspace information
shape, maxshape = determine_data_shape(self.msg_data, offset)
items = int(np.product(shape))
items = int(np.prod(shape))
offset += _padded_size(attr_dict['dataspace_size'], padding_multiple)

# read in the value(s)
Expand Down

0 comments on commit 1a44248

Please sign in to comment.