Return response from Solr downloadWithCredentials

Fixes SolrResult test Fix a typo Issue #1758
NCEAS · Sep 18, 2024 · 9580676 · 9580676
1 parent cc43393
commit 9580676
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/js/models/SolrResult.js b/src/js/models/SolrResult.js
@@ -281,11 +281,13 @@ define(["jquery", "underscore", "backbone"], ($, _, Backbone) => {
       /**
        * Download this object while sending the user's auth token in the
        * request.
+       * @returns {Promise} A promise that resolves to the response object
+       * @since 0.0.0
        */
       async downloadWithCredentials() {
         // Call the new getBlob method and handle the response
-        this.fetchDataObjectWithCredentials()
-          .then((response) => this.downloadFromResposne(response))
+        return this.fetchDataObjectWithCredentials()
+          .then((response) => this.downloadFromResponse(response))
           .catch((error) => this.handleDownloadError(error));
       },
 
@@ -349,9 +351,10 @@ define(["jquery", "underscore", "backbone"], ($, _, Backbone) => {
       /**
        * Download data onto the user's computer from the response object
        * @param {Response} response - The response object from the fetch request
+       * @returns {Response} The response object
        * @since 0.0.0
        */
-      async downloadFromResposne(response) {
+      async downloadFromResponse(response) {
         const model = this;
         const blob = await response.blob();
         const filename = this.getFileNameFromResponse(response);
@@ -377,6 +380,8 @@ define(["jquery", "underscore", "backbone"], ($, _, Backbone) => {
           "Download DataONEObject",
           model.get("id"),
         );
+
+        return response;
       },
 
       /**
@@ -575,7 +580,7 @@ define(["jquery", "underscore", "backbone"], ($, _, Backbone) => {
             model.set("size", $(data).find("size").text() || "");
 
             //Get the entity name
-            model.set("filename", $(data).find("filename").text() || "");
+            model.set("fileName", $(data).find("filename").text() || "");
 
             //Check if this is a metadata doc
             var formatId = $(data).find("formatid").text() || "",

diff --git a/src/js/views/DataObjectView.js b/src/js/views/DataObjectView.js
@@ -297,7 +297,7 @@ define([
         downloadButton.onclick = (e) => {
           e.preventDefault();
           const response = view.response.clone();
-          view.model.downloadFromResposne(response);
+          view.model.downloadFromResponse(response);
         };
         this.buttonContainer.appendChild(downloadButton);
       },