2.26.0 release #2176
Merged
2.26.0 release #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this default in the ADC config
- Enables entering missing value codes in the Attribute editor - Works but lacks styling & unit tests Issue #612
Fix two minor bugs found while testing Issue #612
In new Cesium-based catalog search view Issue #2160
Issue #612
- Use in the EML211 model Issue #1380
Include tests for parsing and updating the DOM when there's a url function Issue #1380
- CitationModel, DataONEObject, SolrResult, and MetadataView previously all used very similar DOI methods - These methods have been moved to the appModel, the other views/models call those - Also added getCanonicalDOIIRI to DataONEObject Relates to #1380
In new Cesium-based catalog search view Issue #2160
- Use in the EML211 model Issue #1380
Include tests for parsing and updating the DOM when there's a url function Issue #1380
- CitationModel, DataONEObject, SolrResult, and MetadataView previously all used very similar DOI methods - These methods have been moved to the appModel, the other views/models call those - Also added getCanonicalDOIIRI to DataONEObject Relates to #1380
Only render the AnnotationFilterWidget when the field is sem_annotation AND the filter type is Filter (not ChoiceFilter) Fixes #2174
Fixes issue #2103
Fixes issue #2052
rushirajnenuji
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
I reviewed and tested this PR for 2.26.0 on my local instance. All the changes and enhancements look great and work as expected. I did run into one issue with the DataONE theme, which Robyn is currently working on. (#2178 -- this will go out in a future release)
Thank you for working on these fixes and this release @robyngit. Excited to see these changes live in production! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release will include 5 new features, 7 bug fixes, and one new app config option:
Improvements
Bug fixes
moreInfoLinkanddownloadLinkare both populated #2170New app config option
emlSystemcan now be specified. This is the system attribute in the main<eml>element. Previously it was hardcoded to "knb".