This is a fake PR to test GH actions #2421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue 2096
globally defined packages are specified in eslint config Issue #2096
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/js/views/TOCView.js
Outdated
| @@ -468,6 +468,14 @@ define([ | |||
| $("body").off("activate"); | |||
| $(window).off("resize"); | |||
| }, | |||
|
|
|||
| tempMethodWithLintingFormattingErrors: function() { | |||
There was a problem hiding this comment.
Unexpected unnamed method 'tempMethodWithLintingFormattingErrors'.
src/js/views/TOCView.js
Outdated
| @@ -468,6 +468,14 @@ | |||
| $("body").off("activate"); | |||
| $(window).off("resize"); | |||
| }, | |||
|
|
|||
| tempMethodWithLintingFormattingErrors: function() { | |||
There was a problem hiding this comment.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected method shorthand.
Suggested change
| tempMethodWithLintingFormattingErrors: function() { | |
| tempMethodWithLintingFormattingErrors() { |
src/js/views/TOCView.js
Outdated
|
|
||
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-const-assign> reported by reviewdog 🐶
'a' is constant.
src/js/views/TOCView.js
Outdated
|
|
||
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'a' is assigned a value but never used.
src/js/views/TOCView.js
Outdated
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; | ||
| b = 99; |
| const a = 1; | ||
| a = 2; | ||
| b = 99; | ||
| console.log("This is a test of the linting errors."); |
There was a problem hiding this comment.
Unexpected console statement.
src/js/views/TOCView.js
Outdated
|
|
||
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-const-assign> reported by reviewdog 🐶
'a' is constant.
src/js/views/TOCView.js
Outdated
|
|
||
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'a' is assigned a value but never used.
src/js/views/TOCView.js
Outdated
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; | ||
| b = 99; |
src/js/views/TOCView.js
Outdated
| const a = 1; | ||
| a = 2; | ||
| b = 99; | ||
| console.log("This is a test of the linting errors."); |
There was a problem hiding this comment.
Unexpected console statement.
src/js/views/TOCView.js
Outdated
Comment on lines
472
to
478
| tempMethodWithLintingFormattingErrors: function() { | ||
| const a = 1; | ||
| a = 2; | ||
| b = 99; | ||
| console.log("This is a test of the linting errors."); | ||
|
|
||
| } |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| tempMethodWithLintingFormattingErrors: function() { | |
| const a = 1; | |
| a = 2; | |
| b = 99; | |
| console.log("This is a test of the linting errors."); | |
| } | |
| tempMethodWithLintingFormattingErrors: function () { | |
| const a = 1; | |
| a = 2; | |
| b = 99; | |
| console.log("This is a test of the linting errors."); | |
| }, |
|
Hi! Thanks for contributing to MetacatUI 🎉 As we strive to improve our code quality, we've implemented automated checks to help ensure all contributions meet the set of standards outlined in the contributing guidelines. All of the checks have passed! ✅ Here's a summary of the checks that were performed:
|
| @@ -468,6 +468,13 @@ define([ | |||
| $("body").off("activate"); | |||
| $(window).off("resize"); | |||
| }, | |||
|
|
|||
| tempMethodWithLintingFormattingErrorsRenamed: function () { | |||
There was a problem hiding this comment.
Unexpected unnamed method 'tempMethodWithLintingFormattingErrorsRenamed'.
| @@ -468,6 +468,13 @@ define([ | |||
| $("body").off("activate"); | |||
| $(window).off("resize"); | |||
| }, | |||
|
|
|||
| tempMethodWithLintingFormattingErrorsRenamed: function () { | |||
There was a problem hiding this comment.
🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Expected method shorthand.
Suggested change
| tempMethodWithLintingFormattingErrorsRenamed: function () { | |
| tempMethodWithLintingFormattingErrorsRenamed () { |
|
|
||
| tempMethodWithLintingFormattingErrorsRenamed: function () { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-const-assign> reported by reviewdog 🐶
'a' is constant.
|
|
||
| tempMethodWithLintingFormattingErrorsRenamed: function () { | ||
| const a = 1; | ||
| a = 2; |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'a' is assigned a value but never used.
| tempMethodWithLintingFormattingErrorsRenamed: function () { | ||
| const a = 1; | ||
| a = 2; | ||
| b = 999; |
Comment on lines
+1
to
+4
| | Test | Result | Local Command | Description | | ||
| |:--------------:|:--------------:|-------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | **Formatting** | {{ .formatting_out_md }} | `npm run format` | Automatically standardizes formatting, checks for syntax errors | | ||
| | **Linting** | {{ .linting_out_md }} | `npm run lint` | Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| | Test | Result | Local Command | Description | | |
| |:--------------:|:--------------:|-------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |
| | **Formatting** | {{ .formatting_out_md }} | `npm run format` | Automatically standardizes formatting, checks for syntax errors | | |
| | **Linting** | {{ .linting_out_md }} | `npm run lint` | Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | | |
| | Test | Result | Local Command | Description | | |
| | :------------: | :----------------------: | ----------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --- | | |
| | **Formatting** | {{ .formatting_out_md }} | `npm run format` | Automatically standardizes formatting, checks for syntax errors | | |
| | **Linting** | {{ .linting_out_md }} | `npm run lint` | Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
| | **Formatting** | {{ .formatting_out_md }} | `npm run format` | Automatically standardizes formatting, checks for syntax errors | | ||
| | **Linting** | {{ .linting_out_md }} | `npm run lint` | Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | | ||
| | **Unit Tests** | {{ .unit_out_md }} | `npm test` | Runs unit tests to ensure that the code changes do not break existing functionality. | | ||
| | **JSDoc** | {{ .jsdoc_out_md }} | `npm run jsdoc-dry-run` | Ensures that building the docs website succeeds and that there are no JSDoc warnings. |s |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| | **JSDoc** | {{ .jsdoc_out_md }} | `npm run jsdoc-dry-run` | Ensures that building the docs website succeeds and that there are no JSDoc warnings. |s | |
| | **JSDoc** | {{ .jsdoc_out_md }} | `npm run jsdoc-dry-run` | Ensures that building the docs website succeeds and that there are no JSDoc warnings. | s | |
Comment on lines
+5
to
+12
| - **Formatting**: {{ .formatting_out_md }} | ||
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | ||
| - **Linting**: {{ .linting_out_md }} | ||
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | ||
| - **Unit Tests**: {{ .unit_out_md }} | ||
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | ||
| - **JSDoc**: {{ .jsdoc_out_md }} | ||
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| - **Formatting**: {{ .formatting_out_md }} | |
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | |
| - **Linting**: {{ .linting_out_md }} | |
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
| - **Unit Tests**: {{ .unit_out_md }} | |
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | |
| - **JSDoc**: {{ .jsdoc_out_md }} | |
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. | |
| - **Formatting**: {{ .formatting_out_md }} | |
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | |
| - **Linting**: {{ .linting_out_md }} | |
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
| - **Unit Tests**: {{ .unit_out_md }} | |
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | |
| - **JSDoc**: {{ .jsdoc_out_md }} | |
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. |
Comment on lines
+9
to
+16
| - **Formatting**: {{ .formatting_out_md }} | ||
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | ||
| - **Linting**: {{ .linting_out_md }} | ||
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | ||
| - **Unit Tests**: {{ .unit_out_md }} | ||
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | ||
| - **JSDoc**: {{ .jsdoc_out_md }} | ||
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| - **Formatting**: {{ .formatting_out_md }} | |
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | |
| - **Linting**: {{ .linting_out_md }} | |
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
| - **Unit Tests**: {{ .unit_out_md }} | |
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | |
| - **JSDoc**: {{ .jsdoc_out_md }} | |
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. | |
| - **Formatting**: {{ .formatting_out_md }} | |
| - Checks for standardized indenting, spacing, line breaks, etc. using [prettier](https://prettier.io/) | |
| - **Linting**: {{ .linting_out_md }} | |
| - Checks JS files for code quality, style issues, and JSdoc comments using [ESLint](https://eslint.org/). Generally follows the [Airbnb style guide](https://github.com/airbnb/javascript) | |
| - **Unit Tests**: {{ .unit_out_md }} | |
| - Runs unit tests to ensure that the code changes do not break existing functionality. If you have added new functionality, please add tests to cover it. | |
| - **JSDoc**: {{ .jsdoc_out_md }} | |
| - Ensures that building the docs website succeeds and that there are no JSDoc warnings. |
Comment on lines
+23
to
+26
| - Run `npm run format` to automatically fix formatting issues | ||
| - Run `npm run lint` to see linting issues | ||
| - Run `npm test` to run unit tests and see any failures | ||
| - Run `npm run jsdoc-dry-run` to see JSDoc warnings |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| - Run `npm run format` to automatically fix formatting issues | |
| - Run `npm run lint` to see linting issues | |
| - Run `npm test` to run unit tests and see any failures | |
| - Run `npm run jsdoc-dry-run` to see JSDoc warnings | |
| - Run `npm run format` to automatically fix formatting issues | |
| - Run `npm run lint` to see linting issues | |
| - Run `npm test` to run unit tests and see any failures | |
| - Run `npm run jsdoc-dry-run` to see JSDoc warnings |
Comment on lines
36
to
38
| eslint_flags: 'src' | ||
| filter_mode: 'diff_context' | ||
|
|
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| eslint_flags: 'src' | |
| filter_mode: 'diff_context' | |
| eslint_flags: "src" | |
| filter_mode: "diff_context" | |
| with: | ||
| github_token: ${{ secrets.GITHUB_TOKEN }} | ||
| reporter: github-pr-review | ||
| filter_mode: 'diff_context' |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| filter_mode: 'diff_context' | |
| filter_mode: "diff_context" |
| id: test | ||
| run: npm test | ||
| continue-on-error: true | ||
|
|
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| @@ -468,6 +468,13 @@ define([ | |||
| $("body").off("activate"); | |||
| $(window).off("resize"); | |||
| }, | |||
|
|
|||
| tempMethodWithLintingFormattingErrorsRenamed: function () { | |||
| const a = 1; | |||
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| const a = 1; | |
| const a = 1; |
Comment on lines
+475
to
+477
| b = 999; | ||
| console.log("This is a test of the linting errors."); | ||
| } |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| b = 999; | |
| console.log("This is a test of the linting errors."); | |
| } | |
| b = 999; | |
| console.log("This is a test of the linting errors."); | |
| }, |
Comment on lines
+36
to
+37
| eslint_flags: 'src' | ||
| filter_mode: 'diff_context' |
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
| eslint_flags: 'src' | |
| filter_mode: 'diff_context' | |
| eslint_flags: "src" | |
| filter_mode: "diff_context" |
| eslint_flags: 'src' | ||
| filter_mode: 'diff_context' | ||
| fail_on_error: true | ||
|
|
There was a problem hiding this comment.
[prettier] reported by reviewdog 🐶
Suggested change
robyngit
force-pushed
the
feature-2096-linting-formatting
branch
2 times, most recently
from
2d57d15
to
92f65bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to test if our setup with reviewdog automatically catches linting and formatting errors on PRs.