Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetadataView & TableEditorView cleanup (Step 1 of issue #1758) #2518

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

robyngit
Copy link
Member

@robyngit robyngit commented Sep 10, 2024

Before adding another feature to MetadataView and the TableEditorView, a little bit of tidying up:

  • Fix eslint issues
  • Add missing JSdocs

Part of issue #1758

and remove unused imports

Issue #1758
@robyngit robyngit force-pushed the feature-1758-data-table-previews-1 branch from e682b3c to a007aec Compare September 10, 2024 19:26
@robyngit robyngit marked this pull request as ready for review September 10, 2024 19:27
@robyngit robyngit force-pushed the feature-1758-data-table-previews-1 branch from a007aec to 8e19d7c Compare September 10, 2024 19:32
@robyngit robyngit changed the title MetadataView cleanup (Step 1 of issue #1758) MetadataView & TableEditorView cleanup (Step 1 of issue #1758) Sep 10, 2024
More robust sorting for edge cases.
Fix issue caused by changing isNaN to Number.isNaN
for eslint fixes.

Issue #1758
@rushirajnenuji rushirajnenuji merged commit e1e8264 into develop Sep 25, 2024
1 check passed
@robyngit robyngit deleted the feature-1758-data-table-previews-1 branch September 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants