Final misc. tasks to support data previews (Step 6 of issue #1758) #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robyngit
commented
Sep 12, 2024
•
robyngit
commented
- Display loading & error msgs in data object view
- Add a download button to the data object view to prevent inflating the metrics (downloads the already fetched data)
- Limit rendering to supported formats and to maximum filesizes
- Make rendering of table data more performant (slow right now for CSVS greated than 2 MB or so)
- Avoids inflating the download metrics, because the data has already been fetched. The download button simply triggers the download of the data file to the user's computer. - Separate out logic for downloading fetched blob in SolrResult so it can be used independently of the DataObjectView
robyngit
changed the title
- Instead of creating an empty table, then populating it, we now add table cell content as it's created - Instead of rendering the table in editing mode then removing editing elements if the table is in view-mode, we now render the table without editing elements if the table is in view-mode - Also use document fragment to append table rows to the table element, which is faster than appending each row individually Issue #1758
- Truncate data and show a message when the table is too large Issue #1758
- Add row numbers to parsed data rather than assuming the first column is the row number - Handle parsing errors more gracefully - Don't show empty CSV lines as data rows - Allow multiple TableEditorView instances on the same page (Fix issues with dropdowns & unique IDs) - Fix issue with adding new rows & cols in editor mode Issue #1758
- Show error message when file type is not supported or file size is too large Issue #1758
Can now initialize DataObjectView with a object ID or SolrModel Issue #1758
Fixes SolrResult test Fix a typo Issue #1758
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
robyngit
force-pushed
the
feature-1758-data-table-previews-6
branch
from
2b6139d
to
7ef5093
Compare
Closed
robyngit
force-pushed
the
feature-1758-data-table-previews-6
branch
from
7ef5093
to
d2df808
Compare
| true, | ||
| ); | ||
| }, | ||
|
|
||
| getInfo: function (fields) { | ||
| var model = this; |
rushirajnenuji
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Hey @robyngit - this looks great, thank you for working on this. 🎉🥳
Good to have the loading and parsing indicator in the modal. 👍🏻
As we extend support for additional file formats in the upcoming release/s, may be we can consider including the file view icon to the actions panel in the data table. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.