-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dropdown filter UI for sem_annotation
field in portal editor
#2539
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <no-var> reported by reviewdog 🐶 metacatui/src/js/views/filters/FilterEditorView.js Lines 44 to 1215 in 1964266
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -291,7 +291,7 @@ define([ | |||||
description: | ||||||
"Allow people to select a search term from a list of options", | ||||||
filterTypes: ["filter"], | ||||||
blockedFields: [...MetacatUI.appModel.get("querySemanticFields")], | ||||||
blockedFields: [], | ||||||
modelFunction: function (attrs) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚫 [eslint] <object-shorthand> reported by reviewdog 🐶
Suggested change
|
||||||
return new ChoiceFilter(attrs); | ||||||
}, | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [eslint] <prefer-arrow-callback> reported by reviewdog 🐶
Unexpected function expression.
metacatui/src/js/views/filters/FilterEditorView.js
Lines 16 to 1217 in 1964266