Skip to content

Commit

Permalink
fix failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Megha-Dev-19 committed Jan 19, 2025
1 parent 3d34dc9 commit 5f5fa57
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ return (
currentTab.title === title ? "active" : "",
].join(" ")}
key={title}
data-testid={title}
>
<div>{title}</div>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async function updateLastProposalId(page) {
async function navigateToMembersPage({ page, instanceAccount }) {
await page.goto(`/${instanceAccount}/widget/app?page=settings`);
await page.waitForTimeout(5_000);
await page.getByText("Members").click();
await page.getByTestId("Members").click();
await expect(page.getByText("All Members")).toBeVisible({ timeout: 10_000 });
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ test.afterEach(async ({ page }, testInfo) => {
async function navigateToThresholdPage({ page, instanceAccount }) {
await page.goto(`/${instanceAccount}/widget/app?page=settings`);
await page.waitForTimeout(5_000);
await page.getByText("Voting Threshold").click();
await page.getByTestId("Voting Threshold").click();
await expect(page.getByText("Permission Groups")).toBeVisible({
timeout: 10_000,
});
Expand Down
2 changes: 1 addition & 1 deletion playwright-tests/tests/settings/theme.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ async function navigateToThemePage({ page, instanceAccount }) {
await updateDaoPolicyMembers({ page });
await updateDaoConfig({ page });
await page.waitForTimeout(5_000);
await page.getByText("Theme & Logo", { exact: true }).click();
await page.getByTestId("Theme & Logo", { exact: true }).click();
await expect(page.getByText("Theme & Logo").nth(1)).toBeVisible();
}

Expand Down
2 changes: 1 addition & 1 deletion playwright-tests/tests/settings/voting-duration.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ test.afterEach(async ({ page }, testInfo) => {
async function navigateToVotingDurationPage({ page, instanceAccount }) {
await page.goto(`/${instanceAccount}/widget/app?page=settings`);
await page.waitForTimeout(5_000);
await page.getByText("Voting Duration").click();
await page.getByTestId("Voting Duration").click();
await expect(
page.getByText("Set the number of days a vote is active.")
).toBeVisible({
Expand Down

0 comments on commit 5f5fa57

Please sign in to comment.