Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart to DAO dashboard #152

Merged
merged 16 commits into from
Dec 20, 2024
Merged

Add chart to DAO dashboard #152

merged 16 commits into from
Dec 20, 2024

Conversation

rubycop
Copy link
Collaborator

@rubycop rubycop commented Dec 3, 2024

Screenshot 2024-12-15 at 17 18 28

@rubycop rubycop requested a review from Megha-Dev-19 December 3, 2024 21:48
@rubycop rubycop changed the title Add chart to DAO dashboard WIP: Add chart to DAO dashboard Dec 3, 2024
@rubycop rubycop changed the title WIP: Add chart to DAO dashboard Add chart to DAO dashboard Dec 15, 2024
@rubycop
Copy link
Collaborator Author

rubycop commented Dec 15, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Dec 15, 2024

@rubycop Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@petersalomonsen 5

Your contribution is much appreciated with a final score of 5!
You have received 50 Sloth points for this contribution

@petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request.

We would appreciate your feedback or contribution idea that you can submit here

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen
Copy link
Collaborator

@rubycop would it be possible to add a playwright test that shows all the usage scenarios? also would be great then to run the test with video mode on, and upload the video files here.

Copy link
Collaborator

@Megha-Dev-19 Megha-Dev-19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be great to have tests. Pre-approving

@rubycop
Copy link
Collaborator Author

rubycop commented Dec 19, 2024

@petersalomonsen
test scenario:

  1. chart is loading
  2. mouse move is working and changes data
  3. switching date period changes data on chart
    https://github.com/user-attachments/assets/7fd58907-f6fb-4934-8630-fbc11d1f7eb1

@petersalomonsen
Copy link
Collaborator

@race-of-sloths score 5

@petersalomonsen
Copy link
Collaborator

Note that you can record test videos by using the video property in playwright.config.js

@rubycop rubycop merged commit 6a9fb5f into main Dec 20, 2024
23 checks passed
@rubycop rubycop deleted the dashboard-chart branch December 20, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants