Added bos workspace #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petersalomonsen the tests doesn't work, can you please help me figure out what's the issue? |
petersalomonsen
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
I think this looks good @Megha-Dev-19 .
It would be interesting, and this could be simplified by also using the bos-workspace for the tests, but currently "Don't ask again" does not work properly with bos-workspace. It is addressed here: NEARBuilders/bos-workspace#114
So let's keep this is mind, so that as soon that issue is fixed, we can also switch to bos-workspace for running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
https://github.com/NEAR-DevHub/neardevhub-treasury-dashboard/assets/100185149/bfd8cc78-4535-4e08-b5a2-373e8455d4c8