Skip to content

Conversation

@strahlw
Copy link
Collaborator

@strahlw strahlw commented Jan 23, 2025

… from the efficiency model

Fixes/Addresses/Summary/Motivation:

Compute efficiency scores for projects based on a dictionary of efficiency scores passed from the efficiency model

Changes proposed in this PR:

  • Modifications on result_parser.py to accept a dictionary and bypass normal efficiency calculations if it is supplied.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my
contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md file
    at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has
    rights to intellectual property that includes these contributions, I represent that I have
    received permission to make contributions and grant the required license on behalf of that
    employer.

@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
primo/opt_model/model_with_clustering.py 75.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
primo/opt_model/result_parser.py 97.31% <100.00%> (+0.07%) ⬆️
primo/opt_model/tests/test_result_parser.py 100.00% <100.00%> (ø)
primo/opt_model/model_with_clustering.py 82.25% <75.00%> (-0.26%) ⬇️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants