-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synced config to Icinga 2 module #117
Conversation
Thanks for the contribution! I'm not sure if we should really collect all loaded configurations from the API. Can you give me the background of what you might need this for other than "what we have, we have"? |
Hm... yes, you're right. In fact, the "currently active" configuration would be totally sufficient. But finding the currently active stage and just collecting this is beyond my Go knowledge for now. |
I would actually not collect the complete config of the active stage, but only collect to the ID of the stage. |
If we need to reproduce errors in testing or for further investigation a copy of the full configuration would be very useful. I guess, using compression for the tarball would massively shrink the space we require for transport |
I have added the active-stage form I would still not add the whole directory itself including content. This is way too much. |
de88b8f
to
746da53
Compare
746da53
to
169f10f
Compare
This PR should add configuration that's sent to the local node. This should collect configuration on every kind of Icinga 2 node including configuration that is managed by Director or via API.
Please take into account, that I'm totally new to the code of this tool. Don't expect that I know what I'm doing.