-
Notifications
You must be signed in to change notification settings - Fork 49
Add multi-threaded benchmarks. #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #173 will not alter performanceComparing Summary
Benchmarks breakdown
Footnotes
|
f75b4cd to
51a110a
Compare
|
Do you know why the benchmarks give so many warnings about system calls? |
Not sure, I reckon it has to do with OpenMP overhead to coordinate the threads. The benchmark mode used runs the code in a virtual CPU and it looks like syscalls are a relevant factor. It's also possible to use wallclock time for the benchmarks, but I am not sure at this stage if there's any benefit for us here. If you enable the syscalls in the flame graphs, you can see e.g. that |
This PR adds threaded versions of the existing NDFT benchmarks.
I have removed the non-OpenMP build jobs where an OpenMP version is available since building with OpenMP is only additive. There's no benefit of keeping the non-OpenMP jobs because we will now just run multi-threaded benchmarks if possible, in addition to the regular ones.