Skip to content

Comments

collection factory feature implemented#359

Merged
Oluwaseyi89 merged 14 commits intoNFTopia-Foundation:mainfrom
feyishola:feat/collection-factory
Jan 30, 2026
Merged

collection factory feature implemented#359
Oluwaseyi89 merged 14 commits intoNFTopia-Foundation:mainfrom
feyishola:feat/collection-factory

Conversation

@feyishola
Copy link
Contributor

closes #341

@Oluwaseyi89
Copy link
Contributor

@feyishola pull our main branch and push again to get updated.

@feyishola
Copy link
Contributor Author

@Oluwaseyi89 done as requested

@Oluwaseyi89
Copy link
Contributor

@feyishola your PR failed checks. Please, review and ensure your code builds and passes all test before pushing your commits.

@Oluwaseyi89
Copy link
Contributor

@feyishola your PR failed checks. Please, review and ensure your code builds and passes all test before pushing your commits.

@feyishola have you done any modification to your code?

@Oluwaseyi89
Copy link
Contributor

Oluwaseyi89 commented Jan 30, 2026

@feyishola are you building the contract at all from your end? See the error its show:


seyi@seyi-Latitude-E5450:~/Documents/nftopia/nftopia/nftopia-stellar$ cargo build
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /home/seyi/Documents/nftopia/nftopia/nftopia-stellar/contracts/collection_factory_contract/Cargo.toml
workspace: /home/seyi/Documents/nftopia/nftopia/nftopia-stellar/Cargo.toml
   Compiling collection-factory v0.1.0 (/home/seyi/Documents/nftopia/nftopia/nftopia-stellar/contracts/collection_factory_contract)
warning: unused import: `symbol_short`
 --> contracts/collection_factory_contract/src/collection.rs:1:51
  |
1 | use soroban_sdk::{Address, Env, Map, String, Vec, symbol_short};
  |                                                   ^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

error[E0308]: mismatched types
   --> contracts/collection_factory_contract/src/collection.rs:209:13
    |
209 |         for &token_id in token_ids.iter() {  // Use &token_id instead of *token_id
    |             ^^^^^^^^^    ---------------- this is an iterator with items of type `u32`
    |             |
    |             expected `u32`, found `&_`
    |
    = note:   expected type `u32`
            found reference `&_`

warning: unused variable: `start_token_id`
   --> contracts/collection_factory_contract/src/collection.rs:173:13
    |
173 |         let start_token_id = <DataKey as Storage>::get_next_token_id(env, collection_id);
    |             ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_start_token_id`
    |
    = note: `#[warn(unused_variables)]` on by default

For more information about this error, try `rustc --explain E0308`.
warning: `collection-factory` (lib) generated 2 warnings
error: could not compile `collection-factory` (lib) due to 1 previous error; 2 warnings emitted
 101 seyi@seyi-Latitude-E5450:~/Documents/nftopia/nftopia/nftopia-stellar$ 


@Oluwaseyi89 Oluwaseyi89 merged commit b831093 into NFTopia-Foundation:main Jan 30, 2026
1 check failed
@Oluwaseyi89
Copy link
Contributor

@feyishola don't worry I'll fix it.

@feyishola
Copy link
Contributor Author

thank you @Oluwaseyi89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a Collection Factory smart contract using Soroban SDK

2 participants