collection factory feature implemented#359
Merged
Oluwaseyi89 merged 14 commits intoNFTopia-Foundation:mainfrom Jan 30, 2026
Merged
collection factory feature implemented#359Oluwaseyi89 merged 14 commits intoNFTopia-Foundation:mainfrom
Oluwaseyi89 merged 14 commits intoNFTopia-Foundation:mainfrom
Conversation
Contributor
|
@feyishola pull our main branch and push again to get updated. |
Contributor
Author
|
@Oluwaseyi89 done as requested |
Contributor
|
@feyishola your PR failed checks. Please, review and ensure your code builds and passes all test before pushing your commits. |
Contributor
@feyishola have you done any modification to your code? |
Contributor
|
@feyishola are you building the contract at all from your end? See the error its show: seyi@seyi-Latitude-E5450:~/Documents/nftopia/nftopia/nftopia-stellar$ cargo build
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package: /home/seyi/Documents/nftopia/nftopia/nftopia-stellar/contracts/collection_factory_contract/Cargo.toml
workspace: /home/seyi/Documents/nftopia/nftopia/nftopia-stellar/Cargo.toml
Compiling collection-factory v0.1.0 (/home/seyi/Documents/nftopia/nftopia/nftopia-stellar/contracts/collection_factory_contract)
warning: unused import: `symbol_short`
--> contracts/collection_factory_contract/src/collection.rs:1:51
|
1 | use soroban_sdk::{Address, Env, Map, String, Vec, symbol_short};
| ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
error[E0308]: mismatched types
--> contracts/collection_factory_contract/src/collection.rs:209:13
|
209 | for &token_id in token_ids.iter() { // Use &token_id instead of *token_id
| ^^^^^^^^^ ---------------- this is an iterator with items of type `u32`
| |
| expected `u32`, found `&_`
|
= note: expected type `u32`
found reference `&_`
warning: unused variable: `start_token_id`
--> contracts/collection_factory_contract/src/collection.rs:173:13
|
173 | let start_token_id = <DataKey as Storage>::get_next_token_id(env, collection_id);
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_start_token_id`
|
= note: `#[warn(unused_variables)]` on by default
For more information about this error, try `rustc --explain E0308`.
warning: `collection-factory` (lib) generated 2 warnings
error: could not compile `collection-factory` (lib) due to 1 previous error; 2 warnings emitted
101 seyi@seyi-Latitude-E5450:~/Documents/nftopia/nftopia/nftopia-stellar$
|
Contributor
|
@feyishola don't worry I'll fix it. |
Contributor
Author
|
thank you @Oluwaseyi89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #341