Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data #3

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Added data #3

merged 3 commits into from
Oct 25, 2024

Conversation

GovertAlkemade
Copy link
Contributor

Added measurements as xlsx, DRN package pre 2022 and eddited stages in the lakes.

added measurements, DRN package pre 2022 and addited stages in the lakes.
@bdestombe
Copy link
Member

Hi Govert,
Thanks for your Pull Request!

Two comments:

  • Could you store the GIS data as geojson with EPSG::28992 ? That works better with git, and the changes can be tracked
  • You are also committing files for pwn_wells and I presume that is unintended.

Thanks!
Bas

@GovertAlkemade GovertAlkemade changed the title added data Added data Oct 22, 2024
@bdestombe
Copy link
Member

Thanks!

One more minor comment. In the repository.yaml a name is written in dutch while the folder naming is in english: Metingen_Vlotter ->Measurements_Vlotter

@GovertAlkemade
Copy link
Contributor Author

It should be Fixed now!

@bdestombe bdestombe merged commit 7ab2673 into NHFLO:main Oct 25, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants