Bump bootstrap-datepicker to 1.7.1 #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with jQuery 3.x
Contributor
|
@miles-smith Any particular reason makes you bump the date-picker to v1.7 rather than the latest v1.10? |
Contributor
Author
No other reason than it was the first version to support jQuery 3.x |
suezhou
approved these changes
Jan 13, 2025
Contributor
suezhou
left a comment
suezhou
left a comment
There was a problem hiding this comment.
The changelog on bootstrap-datepicker is not up-to-date. I think it's fine for us to stick to v1.7.1 rather than bump to the latest.
I'd prefer to include this upgrade in our ndr_ui v4.x version, and I'll merge this PR into bootstrap upgrade branch for the future ndr_ui v5.x version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the vendored version of
bootstrap-datepickerfrom 1.6.0 to 1.7.1, for compatibility with jQuery 3.x.This fixes an issue with datepicker calendar components failing to display.