Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCM-5085: init and compliance #5

Merged
merged 11 commits into from
Jun 5, 2024
Merged

CCM-5085: init and compliance #5

merged 11 commits into from
Jun 5, 2024

Conversation

sidnhs
Copy link
Contributor

@sidnhs sidnhs commented May 30, 2024 •
edited
Loading

Description

Initial terraform compliance and deployment, setting up cloudfront and an empty bucket, setting up dev environment

Context

  1. Configuration for new tf-scaffold bootstrap, configuration for environment specific infrastructure
  2. Pipeline changes for allowing to run terraform compliance job in CI and terraform deployment in CD

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

CI: https://github.com/NHSDigital/nhs-notify-web-platform/actions/runs/9303995960
CD: https://github.com/NHSDigital/nhs-notify-web-platform/actions/runs/9301119017

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

jamesthompson26-nhs
jamesthompson26-nhs approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@jamesthompson26-nhs jamesthompson26-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - presumably DNS and ACM stuff is hashed out for now awaiting delegation or similar?

@sidnhs
Copy link
Contributor Author

sidnhs commented Jun 3, 2024

Looks good - presumably DNS and ACM stuff is hashed out for now awaiting delegation or similar?

Yea we need to have records managed via the dns repo for this so I have temporarily commented that out will uncomment it once we have them set there

mark-r-bjss
mark-r-bjss previously approved these changes Jun 4, 2024
View reviewed changes
@sidnhs sidnhs merged commit 1ce8361 into main Jun 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-r-bjss mark-r-bjss mark-r-bjss approved these changes

@jamesthompson26-nhs jamesthompson26-nhs jamesthompson26-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidnhs @jamesthompson26-nhs @mark-r-bjss